[audioplayers] Fix resource cleanup bugs #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seungsoo47
commented
Jul 15, 2025
seungsoo47
commented
- Handled player resource cleanup in destructor
- Renamed Release() to ReleaseMediaSource() for clearer responsibility
- Handled errors by replacing exceptions in GetDuration() and GetPosition()
- Added logging for unsupported features
- Fixed range limitation of SetVolume() and SetPlaybackRate()
- Handled player resource cleanup in destructor - Renamed Release() to ReleaseMediaSource() for clearer responsibility - Handled errors by replacing exceptions in GetDuration() and GetPosition() - Added logging for unsupported features - Fixed range limitation of SetVolume() and SetPlaybackRate()
JSUYA
reviewed
Jul 16, 2025
JSUYA
reviewed
Jul 16, 2025
seungsoo47
force-pushed
the
dev.plugins.audioplayers.fix.250715
branch
from
052a1e5 to
97abe00
Compare
seungsoo47
force-pushed
the
dev.plugins.audioplayers.fix.250715
branch
from
97abe00 to
7e1508f
Compare
JSUYA
reviewed
Jul 17, 2025
JSUYA
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.